Skip to content

feat: update invalid route handling based on emulator mode #1909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

philasmar
Copy link
Contributor

Description of changes:

  • When a route is not found, API Gateway handles it differently for Rest APIs and Http APIs. This PR updates the behavior to return 404 or 403 based on the current emulator mode.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@philasmar philasmar requested review from normj and a user December 19, 2024 14:55
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good just doc updates

@philasmar philasmar requested a review from a user December 19, 2024 18:38
@philasmar philasmar merged commit 6359a0e into feature/lambdatesttool-v2 Dec 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants